Skip to content

fix::notion-client - Replace ky with got || fix::react-notion-x - LazyImageFull.tsx updated #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix::notion-client - Replace ky with got || fix::react-notion-x - LazyImageFull.tsx updated #646

wants to merge 2 commits into from
+1,557 −1,510

Conversation

mustaqimarifin
Copy link

Description

Replaced KY with GOT

  • KY seems to loop infinitely in localhost for Next 15 bricking the entire session.
  • Latest version of GOT is a near 1:1 replacement

React Lazy Images

  • Very old dependencies and console warnings when using with NextJS
  • Lifted code from react-lazy-images and placed updated code and types in components/lazy-images-full.tsx
  • added react-intersection-observer and unionize

Notion Test Page ID

Can test with a local build of this fork with the examples in the monorepo.

Mustaqim Arifin and others added 2 commits June 26, 2025 19:57
Fix::
1572433 
1 - Replaced `KY` with `GOT` to address looping issues in NextJS
2 - Replaced `React-Lazy-Images` wtih Native Image Component
Fixes: notion-client: - ky pkg replaced with got
67e6165
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Jun 27, 2025 2:43am
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Jun 27, 2025 2:43am

@mustaqimarifin mustaqimarifin mentioned this pull request Jun 27, 2025
Open
@rimonhanna
Copy link
Contributor

rimonhanna commented Jun 28, 2025 •
edited
Loading

@mustaqimarifin collections are no longer loading: https://react-notion-x-minimal-demo-5sgdlsrby-saasify.vercel.app/9cb9716c93164c6c8b4cd0bac3879aeb

@mustaqimarifin
Copy link
Author

mustaqimarifin commented Jun 30, 2025 •
edited
Loading

@mustaqimarifin collections are no longer loading: react-notion-x-minimal-demo-5sgdlsrby-saasify.vercel.app/9cb9716c93164c6c8b4cd0bac3879aeb

i think the minimal demo doesn't import 'Collections', but the full demo does? Because the full demo does indeed load Collections on my end. Thx

Left: Current React-Notion-X Test Suite || Right: Localhost

s22.mp4

@rimonhanna
Copy link
Contributor

true, double checked and all good on the full example including my personal problematic page

@rimonhanna
Copy link
Contributor

@transitive-bullshit can we merge this too?

@rimonhanna
Copy link
Contributor

@transitive-bullshit kind reminder :)

@zsolteszku
Copy link

any update?

@transitive-bullshit
Copy link
Member

there are too many unrelated changes to merge this PR.

#653 was the main fix for collection issues

@transitive-bullshit
Copy link
Member

i'm really hesitant to switch from ky to got without understanding the underlying cause of the infinite loop bug which I haven't been able to repro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustaqimarifin @rimonhanna @zsolteszku @transitive-bullshit